Forum Replies Created
-
AuthorPosts
-
david.h
ParticipantHi,
I am still awaiting this feature and cannot use MetaBox without it.
On March 18 2020 Anh said it was planned for completion in 2020, and on April 28 2020 Long said it was on its way.
However, over one year later there's still no update and MetaBox are not providing an insight on any progress.
It is an essential feature for a professional CMS framework akin to Drupal.
Please can Anh or Long provide a realistic schedule for at least the first public alpha or beta release.
Thanks and regards,
Daviddavid.h
ParticipantI am waiting for this feature too - please can we get an update.
Regards
david.h
ParticipantHi Anh,
I had server hacked once (through a poorly secured web app), so now I'm far more careful.
Try reading through:
https://www.cisecurity.org/controls/cis-controls-list/
Specifically, Control 4 and the principal of least privilege:
https://www.cisecurity.org/spotlight/ei-isac-cybersecurity-spotlight-principle-of-least-privilege/
IMO, this principle should be applied to all dev scenarios, including sanitize_textarea or wp_kses.
Thanks
david.h
ParticipantIf you use clone-as-multiple and want these queries to be really fast, use covering indexes:
http://www.unofficialmysqlguide.com/covering-indexes.html
Thanks
david.h
ParticipantOk,
I think we are focusing on entirely differing viewpoints: back-end vs front-end.
My understanding is that historically Metabox allowed HTML to be posted in textarea fields to aid developers, as Anh says in #19102. However, my concern is for the thousands of new/novice developers who are now using Metabox without detailed knowledge of what is happening in the background.
Since the introduction of MB FrontEnd Submission, many people will be creating public facing front-end forms (e.g. contact, listings, etc) many of which can be submitted without credentials or authentication. Thus, removing all tags and only allowing text in a textarea is what any reasonable person would expect from framework that proclaims "The sleepless nights of endless coding are over". If true, this is a comforting statement, but to be so Metabox must keep patrons' security above aesthetics, ease of function or endlessly accommodating backwards compatibility.
For all the time we've spent discussing this, there could have been a number of relatively simple workarounds implemented - e.g. passing MB FrontEnd Submission textarea fields through sanitize_textarea_field before the default Metabox sanitization of wp_kses_post kicks in - clearly this is not carefully considered solution, but it would work for an interim period of time.
In the WordPress ecosystem, we have all encountered too many sites that have been compromised by plugins devoid of appropriate or adequate security, so please let's try and start something new here - security comes first.
I hope that this thread has opened discussion and thinking that might not have occurred otherwise.
All the best
david.h
ParticipantHi Long/Anh,
Normally I would not reply to an ostensibly "resolved" thread, but this is security related and should not be ignored any longer. There needs to be a solution to the issue you are grappling with which, primarily, seems to be allowing developers to embed HTML in a page using Metabox fields.
This should be done using a specific, preferably dedicated, field type (e.g. HTML or custom) where the sanitation is more relaxed - i.e. wp_kses_post.
The average user should not have to consider whether Metabox has correctly handled sanitization for their custom fields. So, when they create a textarea field (for it's intended purpose - text), this should not be open to abuse by unscrupulous users or bots posting HTML, scripts or suchlike.
Thus, as has been suggested several times in this post, all Metabox fields should be sanitized using the most appropriate WordPress function - i.e. in this instance, sanitize_textarea_field.
Please can you come up with a solid solution.
david.h
ParticipantOk, although I'm not really sure what feedback you are looking for?
1) sanitize_textarea_field is for a textarea field which should be used as per https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea
2) I'm not sure this would be more complicated, its simply a nested array passed to a function which you have already outlined.
david.h
ParticipantHi Anh,
Good job prioritising this - my feedback:
First:
It would be best if all data entry points are sanitized with the most appropriate WordPress function, so this would mean textarea would utilise 'sanitize_textarea_field':
https://developer.wordpress.org/reference/functions/sanitize_textarea_field/
Second:
For any field employing 'wp_kses_post' (WYSIWYG or Custom), allow developers to pass an optional sub-array of tags/protocols to be allowed using:
https://codex.wordpress.org/Plugin_API/Filter_Reference/pre_kses
which is principally based on:
https://codex.wordpress.org/Function_Reference/wp_kses_allowed_html
Third:
Enforce a minimum of 'sanitize_textarea_field' to all custom field types and allow developers to change this, but limited to only one of the built-in WordPress sanitization functions.
Fourth:
Allow developers to bypass WordPress security altogether, (obviously not advised) and implement their own sanitization.
This should only be enabled if a developer (understanding the risks) changes the default setting of sanitize:true to sanitize:custom_callback and provides a working callback function.
Hope this helps,
Daviddavid.h
ParticipantHi Anh,
Having dry-run the code, I pleased to see this heading in the right direction. Remember to keep this on your to-do list, because security should not be a one-time "set it and forget it" thing, but a constant test, evolution, improvement and refinement of the requirements.
Before release, I suggest you employ some white-hat tactics and ask a core-team (maybe from your Facebook group) to try thwarting or circumventing the sanitization using combinations of complex field groups, custom tables, front-end posting and carefully malformed data.
Thanks,
Daviddavid.h
ParticipantOops: XSS attack, not XXS attack.
david.h
ParticipantOk,
But I'm not sure most of your customers will know what they need to do - especially those using MB User Profile and MB FrontEnd Submission where (potentially) anonymous or less trusted users could abuse the system.
I understand your concern regarding managing a whitelist for HTML tags/attributes, but wp_kses_post should handle this without any further configuration required:
https://codex.wordpress.org/Function_Reference/wp_kses_post
Alternatively, at least baseline strip javascript tags/code and links containing javascript as these should never be included in post markup, and can used to create XXS attacks which maliciously affect users browsing the site.
david.h
ParticipantHi Anh,
As firewalls do, you cannot go wrong implementing a default deny policy when coding. Thus, unless you specifically allow something, you deny it - like whitelisting.
The minimum santization you should incorporate for fields which might contain HTML is KSES:
https://codex.wordpress.org/Function_Reference/wp_kses
https://codex.wordpress.org/Function_Reference/wp_kses_post
https://codex.wordpress.org/Plugin_API/Filter_Reference/pre_ksesAdditionally, create separate allowed HTML tag arrays for back-end admins (more open) and front-end users (less open) which can be amended as per requirements.
david.h
ParticipantIf correct, this is quite concerning.
Standard WordPress security should be enabled by default in any plugin or snippet that uses the ecosystem - it should be possible to override this with an option but this should not be necessary in normal circumstances.
Anh, please can you confirm whether this is isolated or across the board.
david.h
Participant+1
Can we get an idea when this will be implemented?
Thanks
david.h
ParticipantI would be interested in an integration between Metabox and Buddypress.
There is a plugin which "syncs" (i.e. duplicates) user/xprofile fields:
https://en-gb.wordpress.org/plugins/bp2wp-full-sync/
But it would be better to natively update the fields like Gravity Forms:
https://docs.gravityforms.com/user-registration-add-on/#buddypress-integration
Hope this can be added to the development roadmap.
Regards
-
AuthorPosts