Meta Box

Support Forum » User Profile

Forum Replies Created

Viewing 15 posts - 856 through 870 (of 3,708 total)
1 2 3 … 57 58 59 … 246 247 248
  • Author
    Posts
  • August 12, 2019 at 11:58 AM in reply to: ✅datepicker not showing on front end #15674
    Anh TranAnh Tran
    Keymaster

    Hi Mary,

    I've just checked and couldn't replicate the error. I recorded a video here:

    https://www.loom.com/share/b309930905274434abebd1ab3c7ef0ea

    Please take a look.

    If you still see the problem, please send me more details or a temporary admin account via the Contact form. I'll take a closer look to your site.

    August 12, 2019 at 11:53 AM in reply to: ✅For loops in MB Blocks with MB Builder #15673
    Anh TranAnh Tran
    Keymaster

    This bug is fixed in version 1.0.3. New version for AIO will come a little later.

    August 12, 2019 at 9:27 AM in reply to: ✅Choice fields filter not working on clonable field #15672
    Anh TranAnh Tran
    Keymaster

    Hi Ryan, this bug is fixed in this commit.

    August 10, 2019 at 3:38 PM in reply to: ✅Choice fields filter not working on clonable field #15667
    Anh TranAnh Tran
    Keymaster

    Oh, I see the problem. After saving, only the 1st input has the filter working. I'll fix it now.

    August 10, 2019 at 3:18 PM in reply to: ✅Taxonomy Advanced - display category thumbnail image #15666
    Anh TranAnh Tran
    Keymaster

    Hi Wojtek,

    If you're on a category/term page, then you can get the term id with get_queried_object_id(). You can also get full term object with get_queried_object().

    August 10, 2019 at 3:16 PM in reply to: ✅datepicker not showing on front end #15665
    Anh TranAnh Tran
    Keymaster

    Hi Mary,

    Do you see any error in the browser console?

    August 10, 2019 at 2:50 PM in reply to: ✅wp-config constant for license key #15664
    Anh TranAnh Tran
    Keymaster

    Hi Austin,

    This is a great idea. I'll work on this now.

    August 10, 2019 at 2:50 PM in reply to: ✅Sanitization of Fields input #15663
    Anh TranAnh Tran
    Keymaster

    Hi Rao,

    I really appreciate your thoughts on this.

    I understand the need for default sanitization. And believe me, this is what I also want to add to the plugin.

    You also pointed out a very important point (point 1), which makes me not pushing the santization so hard. Meta Box is now actively used on 400k+ websites. Any change we make will affect these huge amount of websites. I can't notify the developers (there's no way to let them know because WordPress.org doesn't provide any way to contact to them). So, I decide to not implement a forced / opinionated sanitization at the moment. I have to be very careful about this.

    Another thing that people should consider is: Meta Box is not an end-user tools. It's a tool for developers which provides API. So there's nothing like Meta Box --> Users, but it's more like Meta Box --> Developers --> Users. Because of this, developers understand which kind of data they want their users to enter. And thus, a sanitization callback fits this situation.

    If you're building a new plugin / solution using Meta Box, why don't you implement this with just a few lines of code instead of depending the default sanitization which might not work smoothly in all cases?

    There are also a few things regarding sanitization in WordPress, that I think worth mentioning:

    • Admins can enter script and style in the post content, regardless the santiziation of wp_kses_post.
    • Customizer API requires (not strictly) developers to enter santiziation callback. If no sanitization callback, then what users enter will be used.
    • wp_insert_post doesn't do any sanitization for the content when inserting the post programmatically.

    Anyway, there is a default sanitization for some fields (email, url, file_input, checkboxes). For other fields, due to the nature of the complexity, I haven't implemented that. If you have any idea on which proper sanitization for each field type, please let me know.

    August 8, 2019 at 1:49 PM in reply to: ✅MB Blocks not listed in AIO extension #15646
    Anh TranAnh Tran
    Keymaster

    Hi Georgina,

    The AIO plugin includes MB Blocks. Can you please check that again?

    August 7, 2019 at 12:46 PM in reply to: ✅Sanitization of Fields input #15639
    Anh TranAnh Tran
    Keymaster

    I've added support for sanitize_callback here. Please try it and let me know if you need any improvement.

    August 7, 2019 at 10:59 AM in reply to: ✅Choice fields filter not working on clonable field #15638
    Anh TranAnh Tran
    Keymaster

    Hi Ryan,

    I've just done a quick test and it works for me. Here is the code I'm using to register a meta box and filter the label:

    add_filter( 'rwmb_meta_boxes', function( $meta_boxes ) {
    $meta_boxes[] = [
        'title' => 'Cloneable Post Field',
        'fields' => [
            [
                'id' => 'p',
                'title' => 'Post',
                'type' => 'Post',
                'clone' => true,
            ],
        ],
    ];
    return $meta_boxes;
} );

add_filter( 'rwmb_p_choice_label', function ( $label, $field, $post ) {
    return "$post->post_type: $post->post_title";
}, 10, 3 );

    And here is the screenshot:

    https://prnt.sc/opcstu

    August 7, 2019 at 10:48 AM in reply to: ✅Choice fields filter not working on clonable field #15637
    Anh TranAnh Tran
    Keymaster

    Hi Ryan,

    Thanks for your feedback. Let me check that again and will get back to you soon.

    August 7, 2019 at 10:48 AM in reply to: ✅For loops in MB Blocks with MB Builder #15636
    Anh TranAnh Tran
    Keymaster

    After debugging, I found a JS bug that doesn't collect correct values from cloneable/group fields. I'll fix it and update the plugin as soon as I can.

    August 7, 2019 at 10:46 AM in reply to: ✅Seeing an Uncaught TypeError with twig in AIO 1.9.2 #15635
    Anh TranAnh Tran
    Keymaster

    Thanks for valuable info. I intended to use the latest 2.x version of Twig, but it requires PHP 7.0 which is quite high at the moment. So I decided to use the latest 1.x version only.

    Looks like both plugins are using Composer and it doesn't handle the version conflict quite well. The best solution is both plugins should use only stable API from Twig so they don't change across versions. But as you said, 2FAS might use deprecated APIs. I'll take a look at that plugin to see if I can make some hooks to let users choose Twig version or disable bundled Twig in MB Builder.

    August 6, 2019 at 4:38 PM in reply to: ✅For loops in MB Blocks with MB Builder #15621
    Anh TranAnh Tran
    Keymaster

    Hi Jose,

    For math, please use {{ (a + b) / 2 }}.

    Regarding the cloneable fields, let me try it and will get back to you soon.

  • Author
    Posts
Viewing 15 posts - 856 through 870 (of 3,708 total)
1 2 3 … 57 58 59 … 246 247 248