Meta Box

Hi, what is the problem that you experienced? Can you provide more details?

Also, please go to Dashboard > Updates and click "Check Again" button. That might refresh the updates.

Hi,

Did you create a meta box with premium_categories field for the users?

Hey guys,

I finish the code for the sanitizer part.

It works like this:

• Sanitization is auto applied for all built-in types.
• For custom field types, developers needs to implement their sanitization via sanitize_callback parameter. If no sanitize callback is provided, the field won't be sanitize. I do this to not break the websites at the moment. In the future, I might add default sanitization for all custom field types if sanitize_callback is not defined. At this stage, I think this is enough.
• Developers can also bypass sanitization by setting 'sanitize_callback' => 'none' (if set to a callable, it will be used for sanitization).

I'll merge the commits and release a new version for Meta Box next week.

Thank you all for your feedback!

Hey guys,

Thanks for your feedback. Based on what FED offered, I think this patch is a little better. Can you please try replace the line 240 in the conditional-logic.js with this?

if ( ! isGutenbergElement( logic[0] ) && ! dependentFieldSelector && $scope && $scope.hasClass( 'rwmb-group-clone' ) ) {

I'll release a new version when it's confirmed. Thanks!

Hi David,

Your feedback is great and that's exactly what I'm looking for. My reply above was just a discussion about your ideas.

I'll consider your suggestions. Thanks.

Hi,

I found the problem. You're using a child theme, and in the register.php function that registers the block it refers to the parent theme folder:

'render_template' => get_template_directory() . '/blocks/hero/template.php',
'enqueue_style'   => get_template_directory_uri() . '/blocks/hero/style.css',

It should change to:

'render_template' => get_stylesheet_directory() . '/blocks/hero/template.php',
'enqueue_style'   => get_stylesheet_directory_uri() . '/blocks/hero/style.css',

I made the change in your site and it works.

Hi David,

Thanks for your feedback. Yes, I want to complete this thing as it's important and I don't want to postpone at the middle.

Regarding your feedback:

1. I think sanitize_textarea_field is too limited. It seems fine with the function name, but people usually use it for HTML content. I'm using wp_kses_post, which I think is okay.
2. Adding params for wp_kses_post can be done. But it will make the code more complicated in both plugin's side and developer's side. I think in this case, developers can do that easier with a custom sanitize callback like this:

'sanitize_callback' => function( $value ) {
    $allowed_tags = [];
    return wp_kses( $value, $allowed_tags );
}

1. I'm thinking about this, too. Need to find a good way to implement that without breaking things.
2. That's available via custom sanitize_callback param (see the example above). Developers can define their own sanitize callback or bypass the sanitization with this code:

'sanitize_callback' => function( $value ) { return $value; }

Hi David,

Glad you like it. I've just pushed the finished code to the "sanitize" branch. The full code is now available here.

There are also some things left that I would love to hear your feedback:

• textarea field: at the moment, I force to use wp_kses_post as default. But as I said in a reply earlier, some developers make this field available for users to enter scripts (such as Google Analytics or Google Adsense). What do you think best in this way? Is forcing a callback is good?
• Custom field type are not sanitized by default. Developers are required to sanitize themselves. Do you think it's fine? Or forcing a default sanitize callback?