Prevent sortable nested group being able to be moved outside of its parent.

This topic has 12 replies, 2 voices, and was last updated 6 years, 9 months ago by wptriad.

Viewing 13 posts - 1 through 13 (of 13 total)

Author

Posts
January 21, 2018 at 11:30 AM #8276

wptriad
Participant

Currently, sortable cloneable nested group can be moved outside of its parent group which most on the time is unexpected behavior and will definitely mess up meta boxes data. Also it's extremely difficult to sort cloneable nested groups inside their parent (which is also sortable cloneable group) because the drop placeholder is always outside of the parent.

Another similar issue is that sortable cloneable parent group can be moved inside of another parent group. Notice that all the groups mentioned are collapsible group. I didn't test if the issue occurs for non-collapsible group.

It would be great if these issues are fixed because with their current state, the sortable cloneable nested group feature is rendered unusable.

Below is the code for registering meta boxes:

https://pastebin.com/b27yAciK

Thanks,

Add New Note to this Reply

January 21, 2018 at 2:05 PM #8278

wptriad
Participant

An additional note is that the issues happen only to the newly cloned parent group and its children, not the first group.

Add New Note to this Reply

January 22, 2018 at 10:11 AM #8283

Anh Tran
Keymaster

Hi, I've fixed it on Github. Can you try it?

Add New Note to this Reply

January 22, 2018 at 4:31 PM #8287

wptriad
Participant

Thank you, I will try it and let you know later.

Add New Note to this Reply

January 23, 2018 at 10:08 AM #8301

wptriad
Participant

Hi Tran,

I tested it and I didn't see any difference, the issues are still there. Could you please take a look at it once more?

Add New Note to this Reply

January 23, 2018 at 10:30 AM #8302

Anh Tran
Keymaster

Have you cleared the browser cache? The fix is in JS and requires to clear cache to get the fresh version.

Add New Note to this Reply

January 23, 2018 at 10:42 AM #8303

wptriad
Participant

Yes I did clear the browser cache. Note that the issue only occurs in newly cloned group. If the issue is fixed on your side, can you inform me what your current configs of Meta Box plugins? FYI I also have MB Show Hide in use.

Add New Note to this Reply

January 23, 2018 at 1:47 PM #8304

Anh Tran
Keymaster

I tested with you code only:

https://i.imgur.com/NQy6Ot9.png

Here is how it works:

https://imgur.com/a/KQfkA

Add New Note to this Reply

January 23, 2018 at 6:11 PM #8306

wptriad
Participant

OK, so i tried deactivating all the other Meta Box plugins (MB Term Meta, Meta Box Conditional Logic, Meta Box Show Hide) then tested the code again and it worked. After that, I activated the other Meta Box plugins then tested for one more time and this time it worked too! So honestly I have no idea what prevented it from working right after the js fix.

However, the parent group still can be placed inside another parent group, I don't know if you did test it?

Thank you for your time, I appreciate it!

Add New Note to this Reply

January 31, 2018 at 2:27 PM #8411

Anh Tran
Keymaster

Hi again, this bug is fixed.

Add New Note to this Reply

January 31, 2018 at 2:54 PM #8412

wptriad
Participant

I tested it and although a parent group can't be dragged inside another parent group, there's a new issue. You now can't sort the child group because when you try to drag the child group, its whole parent group will be dragged. The issue occurs to newly cloned parent group only. Could you please take a look at it?

Thanks.

Add New Note to this Reply

February 1, 2018 at 2:56 PM #8424

Anh Tran
Keymaster

Hi, I tried that and couldn't replicate the bug. Here is what I have:

https://imgur.com/a/CYP77

Can you try again?

Add New Note to this Reply

February 1, 2018 at 3:27 PM #8425

wptriad
Participant

OK so that was my fault, I downloaded the latest Meta Box Group but installed the older version by mistake. After reinstalling the latest version (1.2.12), the issue was gone.

Thanks you very much for your help!

Add New Note to this Reply
Author

Posts

Viewing 13 posts - 1 through 13 (of 13 total)

The topic ‘Prevent sortable nested group being able to be moved outside of its parent.’ is closed to new replies.