Small bug in Loader.php

Support Meta Box AIO Small bug in Loader.phpResolved

Viewing 5 posts - 1 through 5 (of 5 total)
  • Author
    Posts
  • #36197
    Kurt BriffaKurt Briffa
    Participant

    Hello,

    I believe there is a small bug in your latest update (1.16.1) for MB AIO in

    /meta-box-aio/vendor/meta-box/mb-settings-page/src/Loader.php

    on line 22:

    return strlen( $a['parent'] ) - strlen( $b['parent'] );

    --

    I added an isset check and everything seems to be working fine.

    usort( $settings_pages, function ( $a, $b ) {
        if ( isset( $a['parent'] ) ) {
            return strlen( $a['parent'] ) - strlen( $b['parent'] );
        }
    } );

    Regards,
    Sam Hayman

    #36211
    Long NguyenLong Nguyen
    Moderator

    Hi Kurt,

    Thank you for your feedback.

    Can you please let me know how to reproduce the issue and share the error log?

    #36216
    Kurt BriffaKurt Briffa
    Participant

    Hi Long,

    I did not get any errors in log. We're using MB AIO as an MU Plugin and we have it in a private repo for strict version control.

    We're using it inside a Roots Bedrock / Sage installation and pulling it through composer. All we did was an update to version 1.16.1. To be honest, I have no idea what version there was before, but the last update happened around November 2021.

    I'm not sure if this helps - https://i.postimg.cc/g2SDTdgy/Loader.png

    Regards,
    Sam

    #36481
    ambrdigitalambrdigital
    Participant

    We are getting the warring Notice as well.

    Warning: Undefined array key "parent" in /Applications/XAMPP/xamppfiles/htdocs/505junk.com/wp-content/plugins/meta-box-aio/vendor/meta-box/mb-settings-page/src/Loader.php on line 22

    Cheers,
    Anthony

    #36493
    Long NguyenLong Nguyen
    Moderator

    Hi,

    Thank you for your feedback.

    This issue has been fixed in a new commit. It will be included in the next update of this plugin.

Viewing 5 posts - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.