TypeError: logics is undefined - Page 2

This topic has 21 replies, 6 voices, and was last updated 4 years, 6 months ago by Anh Tran.

Viewing 7 posts - 16 through 22 (of 22 total)

← 1 2

Author

Posts
April 28, 2020 at 3:58 PM #19335

Aart Jan van der Linden
Participant

Dear Anh,

I managed to reproduce the error by entering this code in a WYSIWYG field with a 'hidden' condition:
<header id="entry-header" class="entry__header yr-entry-header" data-rapid-sec="{"entry-header":"entry-header"}"></header>

Somehow this makes the value of the data-conditions attribute invalid JSON.

(It turned out one of my co-workers pasted this messy HTML from another site in a WYSIWYG-field, this is part of the HTML)

Hope this helps..?

Best,

AJ

Add New Note to this Reply

April 28, 2020 at 9:53 PM #19343
Austin Passy
Participant
Sorry, I am unable to paste my code as it's 20 post types, and thousands of custom fields.

But I was able to spot incorrect JSON in the data-conditions attribute which may help. It would seem that double quoted aren't getting encoded properly.

When I changed the get_conditional_html (and reverted the JS changes) I no longer see the logics errors.
```
esc_attr( htmlspecialchars( wp_json_encode( $conditions ), ENT_QUOTES, 'UTF-8' ) )
  
```
This was the json condition (part of it that didn't get encoded/escaped properly):
```
"desc": "Alphanumeric, no special characters except for " - ".",
```
Hope this helps.

Add New Note to this Reply
April 29, 2020 at 10:38 AM #19357

Anh Tran
Keymaster

Thanks a lot for your feedback! Looks like the json encode is the problem. I'll check and fix that.

Add New Note to this Reply

April 29, 2020 at 11:19 AM #19360
Anh Tran
Keymaster
Hey guys, can you help me to test the fix before releasing a new version? Please try changing parse_conditions function to:
```
private function parse_conditions( $conditions ) {
    $output = [];
    if ( ! empty( $conditions['visible'] ) ) {
        $output['visible'] = $this->parse_condition( $conditions['visible'] );
    }
    if ( ! empty( $conditions['hidden'] ) ) {
        $output['hidden'] = $this->parse_condition( $conditions['hidden'] );
    }
    return $output;
}
```
The previous code does JSON-encode all field settings, which contains something like field description and value, which might break the JSON. The new code only encodes the conditions, which eliminate this issue and might improve the performance as well.

Add New Note to this Reply
April 29, 2020 at 10:20 PM #19377

Austin Passy
Participant

Thanks, I will test this today and report back.

Add New Note to this Reply

April 30, 2020 at 12:08 AM #19380

Austin Passy
Participant

Validated the updated function is working without issues.

Add New Note to this Reply

April 30, 2020 at 9:57 AM #19387

Anh Tran
Keymaster

Thank you!

I've released a new version for Meta Box Conditional Logic. The update for AIO will come next week.

Add New Note to this Reply
Author

Posts

Viewing 7 posts - 16 through 22 (of 22 total)

← 1 2

You must be logged in to reply to this topic.